Skip to content

Added Suppress Inspection Annotations To PrisonerEvents.properties #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

IllianiBird
Copy link
Collaborator

  • Suppressed "UnusedMessageFormatParameter" inspection for the entire file.
  • Suppressed "UnusedProperty" inspection for the entire file.

Dev Notes

This just suppresses these warnings, so that it's easier to spot if there are actual issues at play.

The former is irrelevant because of how i18n works - you no longer need to have placeholders in the right order, or always include every placeholder.

The latter is irrelevant because we dynamically build the reference key, rather than direct referencing. So IDEA thinks the entries aren't being used.

- Suppressed "UnusedMessageFormatParameter" inspection for the entire file.
- Suppressed "UnusedProperty" inspection for the entire file.
@IllianiBird IllianiBird self-assigned this Mar 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.12%. Comparing base (4e292ff) to head (161de25).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6203   +/-   ##
=========================================
  Coverage     11.12%   11.12%           
- Complexity     6421     6422    +1     
=========================================
  Files          1062     1062           
  Lines        140674   140674           
  Branches      20943    20943           
=========================================
+ Hits          15645    15654    +9     
+ Misses       123404   123394   -10     
- Partials       1625     1626    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@psikomonkie psikomonkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I'll need to start doing this to property files I work on that have dynamically generated keys. I don't run into the unused property often, but it's good to know how to suppress it.

@IllianiBird
Copy link
Collaborator Author

I stumbled across the how entirely by accident. I use dynamic references a lot, nowadays, so it’s a tool I’ll be using a lot.

@IllianiBird IllianiBird merged commit 0f13a72 into MegaMek:master Mar 10, 2025
4 checks passed
@IllianiBird IllianiBird deleted the prisonerEventResourceTags branch March 23, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants